-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1771 - add module for secure redirect #7983
Merged
lachlan-roberts
merged 3 commits into
jetty-10.0.x
from
jetty-10.0.x-1771-secureRedirectHandler
May 30, 2022
Merged
Issue #1771 - add module for secure redirect #7983
lachlan-roberts
merged 3 commits into
jetty-10.0.x
from
jetty-10.0.x-1771-secureRedirectHandler
May 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
previously requested changes
May 12, 2022
joakime
reviewed
May 12, 2022
gregw
requested changes
May 16, 2022
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
olamy
force-pushed
the
jetty-10.0.x-1771-secureRedirectHandler
branch
from
May 24, 2022 06:53
6e09c21
to
32ed6fa
Compare
gregw
previously approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but see note about doco
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
May 25, 2022
lachlan-roberts
dismissed
sbordet’s stale review
May 30, 2022 01:58
changes were made to address review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1771